yuqi1129 commented on PR #8240: URL: https://github.com/apache/gravitino/pull/8240#issuecomment-3220116892
> > Accordingly to [docs](https://gravitino.apache.org/docs/0.9.1/jdbc-doris-catalog), the version is `1.2.x`, it hard to tell whether it is `1.2.0/1.2.1` or a higher version(1.2.2+)? So, is there any way to support both? > > Good point, here are some approaches to support both: > > Option 1: Graceful degradation > > * Keep the parsing logic to handle BUCKETS AUTO > * When actually executing against Doris, if it fails due to unsupported syntax, we could catch the error and provide a > helpful message > * This way newer Doris versions work seamlessly, older versions get clear feedback > > Option 2: Runtime version detection > > * Add a version check against the Doris instance > * Parse BUCKETS AUTO only if version >= 1.2.2 > * Requires adding version detection logic to the catalog > > Option 3: Configuration-based > > * Add a catalog property like doris.support.auto.buckets=true/false > * Let users configure based on their Doris version > * Default to false for backward compatibility > > Option 4: Keep current approach > > * The existing codebase already had partial AUTO support (HASH variant worked) > * This suggests the maintainers expected AUTO support > * We're just fixing the RANDOM variant bug > > I'd lean toward Option 1, it's the least disruptive and provides the best user experience. What do you think? Yeah, solution one is more graceful, and the change is less intrusive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
