jerryshao commented on code in PR #8212:
URL: https://github.com/apache/gravitino/pull/8212#discussion_r2290025250
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/converter/HiveDataTypeConverter.java:
##########
@@ -116,7 +117,17 @@ public TypeInfo fromGravitino(Type type) {
Types.StructType structType = (Types.StructType) type;
List<TypeInfo> typeInfos =
Arrays.stream(structType.fields())
- .map(t -> fromGravitino(t.type()))
+ .map(
+ t -> {
+ // Hive does not support comments in struct fields. This
is no way to preserve
+ // comments in struct fields when converting from
Gravitino to Hive.
+ // See: https://issues.apache.org/jira/browse/HIVE-26593
+ Preconditions.checkArgument(
+ t.comment() == null,
+ "Hive does not support comments in struct fields:
%s",
+ t.name());
+ return fromGravitino(t.type());
+ })
Review Comment:
Compared to throwing an exception. In my opinion, it is better to add a
warning log and ignore the comment field for Hive table. What do you think?
Directly throwing an exception and failing the request seems too strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
