jerryshao commented on code in PR #8190:
URL: https://github.com/apache/gravitino/pull/8190#discussion_r2287283849
##########
core/src/main/java/org/apache/gravitino/cache/CaffeineEntityCache.java:
##########
@@ -228,7 +241,8 @@ public <E extends Entity & HasIdentifier> void put(E
entity) {
() -> {
invalidateOnKeyChange(entity);
NameIdentifier identifier = getIdentFromEntity(entity);
- EntityCacheKey entityCacheKey = EntityCacheKey.of(identifier,
entity.type());
+ EntityCacheRelationKey entityCacheKey =
+ EntityCacheRelationKey.of(identifier, entity.type());
Review Comment:
How do you know that for some entity types, we need to update the entity
when the related entity is updated/deleted? For example, if the role is
deleted, we need to update the user entity, here I don't see the specific logic
to handle this. I think we should have a specific logic to check the entity
type and do some specific logic. It is hard to make it generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
