justinmclean commented on code in PR #8120:
URL: https://github.com/apache/gravitino/pull/8120#discussion_r2280821247
##########
core/src/main/java/org/apache/gravitino/hook/AccessControlHookDispatcher.java:
##########
@@ -192,9 +191,10 @@ public boolean deleteRole(String metalake, String role)
throws NoSuchMetalakeExc
log.debug(e.getMessage());
}
boolean resultOfDeleteRole = dispatcher.deleteRole(metalake, role);
- if (oldRole != null) {
- notifyRoleUserRelChange(((RoleEntity) oldRole).id());
- }
+
+ if(resultOfDeleteRole && oldRole!= null)
+ notifyRoleUserRelChange(metalake,role)
+
Review Comment:
I'm also not sure why you have changed the parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
