justinmclean opened a new issue, #8110:
URL: https://github.com/apache/gravitino/issues/8110

   ### What would you like to be improved?
   
   The issue is here:
   ```
   && (scheme == null ? that.authority == null : scheme.equals(that.scheme))
   && (authority == null ? that.authority == null : 
authority.equals(that.authority))
   ```
   
   Here's a unit test for it:
   ```
     @Test
     public void testEqualsWhenSchemeIsNull() {
       Map<String, String> conf = Collections.singletonMap("key", "val");
       FilesetCatalogOperations.FileSystemCacheKey key1 =
           new FilesetCatalogOperations.FileSystemCacheKey(null, "auth", conf);
       FilesetCatalogOperations.FileSystemCacheKey key2 =
           new FilesetCatalogOperations.FileSystemCacheKey(null, "auth", conf);
   
       assertEquals(key1, key2);
       assertEquals(key1.hashCode(), key2.hashCode());
     }
   ```
   
   ### How should we improve?
   
   Use that.scheme not that.authority in the first line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to