yuqi1129 commented on code in PR #8079:
URL: https://github.com/apache/gravitino/pull/8079#discussion_r2276587350
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/TableColumnMetaService.java:
##########
@@ -143,8 +143,12 @@ void updateColumnPOsFromTableDiff(
List<ColumnPO> columnPOsToInsert = Lists.newArrayList();
for (ColumnEntity newColumn : newColumns.values()) {
ColumnEntity oldColumn = oldColumns.get(newColumn.id());
- // If the column is not existed in old columns, or if the column is
updated, mark it as UPDATE
- if (oldColumn == null || !oldColumn.equals(newColumn)) {
Review Comment:
This depends on the real definition of `ColumnPO.ColumnOpType.CREATE` and
`ColumnPO.ColumnOpType.UPDATE`.
Based on previous code, changes introduced by `JDBCBackend#update` will be
marked as `UPDATE`, and `JDBCBackend#insert` will be viewed as `CREATE`
operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
