(gravitino) branch main updated: improvement(iceberg): remove useless injectTableConfig while loading table. (#8068)

[fanng]

This is an automated email from the ASF dual-hosted git repository.

fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 51f58fd201 improvement(iceberg): remove useless injectTableConfig 
while loading table. (#8068)
51f58fd201 is described below

commit 51f58fd201b308b42645d2f9503863265ede995d
Author: Yujiang Zhong <42907416+zhongyuji...@users.noreply.github.com>
AuthorDate: Thu Aug 14 18:01:32 2025 +0800

    improvement(iceberg): remove useless injectTableConfig while loading table. 
(#8068)
    
    ### What changes were proposed in this pull request?
    remove unnecessary injectTableConfig in `IcebergCatalogWrapper`
    
    ### Why are the changes needed?
    #6021 moves the the credential injection from `IcebergCatalogWrapper` to
    `CatalogWrapperForREST#injectCredentialConfig` while loading table. Now
    the `IcebergCatalogWrapper.injectTableConfig` only performs an
    unnecessary `loadTableResponse` copy, which should be removed.
    
    
    ### Does this PR introduce any user-facing change?
    No.
    
    ### How was this patch tested?
    Existing tests.
---
 .../gravitino/iceberg/common/ops/IcebergCatalogWrapper.java | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git 
a/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java
 
b/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java
index 0baf74885c..9f96e36b08 100644
--- 
a/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java
+++ 
b/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java
@@ -24,7 +24,6 @@ import java.sql.DriverManager;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Optional;
-import java.util.function.Supplier;
 import lombok.Getter;
 import lombok.Setter;
 import org.apache.commons.lang3.StringUtils;
@@ -162,9 +161,9 @@ public class IcebergCatalogWrapper implements AutoCloseable 
{
   public LoadTableResponse createTable(Namespace namespace, CreateTableRequest 
request) {
     request.validate();
     if (request.stageCreate()) {
-      return injectTableConfig(() -> CatalogHandlers.stageTableCreate(catalog, 
namespace, request));
+      return CatalogHandlers.stageTableCreate(catalog, namespace, request);
     }
-    return injectTableConfig(() -> CatalogHandlers.createTable(catalog, 
namespace, request));
+    return CatalogHandlers.createTable(catalog, namespace, request);
   }
 
   public void dropTable(TableIdentifier tableIdentifier) {
@@ -176,7 +175,7 @@ public class IcebergCatalogWrapper implements AutoCloseable 
{
   }
 
   public LoadTableResponse loadTable(TableIdentifier tableIdentifier) {
-    return injectTableConfig(() -> CatalogHandlers.loadTable(catalog, 
tableIdentifier));
+    return CatalogHandlers.loadTable(catalog, tableIdentifier);
   }
 
   public boolean tableExists(TableIdentifier tableIdentifier) {
@@ -295,12 +294,6 @@ public class IcebergCatalogWrapper implements 
AutoCloseable {
     closeDriverLoadedByIsolatedClassLoader(catalogUri);
   }
 
-  // Some io and security configuration should pass to Iceberg REST client
-  private LoadTableResponse injectTableConfig(Supplier<LoadTableResponse> 
supplier) {
-    LoadTableResponse loadTableResponse = supplier.get();
-    return 
LoadTableResponse.builder().withTableMetadata(loadTableResponse.tableMetadata()).build();
-  }
-
   @Getter
   @Setter
   public static final class IcebergTableChange {