justinmclean opened a new issue, #8084:
URL: https://github.com/apache/gravitino/issues/8084
### What would you like to be improved?
Missing inherited in hashCode and equals in
common/src/main/java/org/apache/gravitino/dto/tag/TagDTO.java
Unit test that shows this:
```
@Test
public void testEqualsConsidersInherited() {
AuditDTO audit =
AuditDTO.builder().withCreator("user1").withCreateTime(Instant.now()).build();
TagDTO ownedTag =
TagDTO.builder()
.withName("tag_test")
.withComment("tag comment")
.withAudit(audit)
.withInherited(Optional.of(false))
.build();
TagDTO inheritedTag =
TagDTO.builder()
.withName("tag_test")
.withComment("tag comment")
.withAudit(audit)
.withInherited(Optional.of(true))
.build();
Assertions.assertNotEquals(ownedTag, inheritedTag);
}
```
### How should we improve?
fix hashCode and equals methods to include inherited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
