justinmclean commented on code in PR #8070:
URL: https://github.com/apache/gravitino/pull/8070#discussion_r2275041943
##########
authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationProperties.java:
##########
@@ -34,7 +34,7 @@ public JdbcAuthorizationProperties(Map<String, String>
properties) {
}
private void check(String key, String errorMsg) {
- if (!properties.containsKey(key) && properties.get(key) != null) {
+ if (!properties.containsKey(key)) {
Review Comment:
in case like this is best you make a little chart 2x2 with the key existing
and not existing vs the property being null or not, you can work out the
correct logic for from that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
