This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 7f4e4472c9 [#8031] improvement(InternalClientType): null check to
prevent NPE (#8074)
7f4e4472c9 is described below
commit 7f4e4472c944f1de2e2b2dc503bc2c918d211d7a
Author: Sambhavi Pandey <[email protected]>
AuthorDate: Thu Aug 14 06:42:33 2025 +0530
[#8031] improvement(InternalClientType): null check to prevent NPE (#8074)
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
This will prevent a possible NPE by validating if the param is null
before proceeding with other checks
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: #8031
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change,
including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
### How was this patch tested?
unit testing
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
---
.../apache/gravitino/audit/InternalClientType.java | 3 ++
.../gravitino/audit/InternalClientTypeTest.java | 52 ++++++++++++++++++++++
2 files changed, 55 insertions(+)
diff --git
a/common/src/main/java/org/apache/gravitino/audit/InternalClientType.java
b/common/src/main/java/org/apache/gravitino/audit/InternalClientType.java
index 516f5e263a..360f92111d 100644
--- a/common/src/main/java/org/apache/gravitino/audit/InternalClientType.java
+++ b/common/src/main/java/org/apache/gravitino/audit/InternalClientType.java
@@ -41,6 +41,9 @@ public enum InternalClientType {
* @return true if the client type is valid, false otherwise
*/
public static boolean checkValid(String clientType) {
+ if (clientType == null) {
+ return false;
+ }
try {
InternalClientType.valueOf(clientType);
return true;
diff --git
a/common/src/test/java/org/apache/gravitino/audit/InternalClientTypeTest.java
b/common/src/test/java/org/apache/gravitino/audit/InternalClientTypeTest.java
new file mode 100644
index 0000000000..2f65fd0abe
--- /dev/null
+++
b/common/src/test/java/org/apache/gravitino/audit/InternalClientTypeTest.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.audit;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+public class InternalClientTypeTest {
+
+ @Test
+ public void testCheckValid() {
+ Assertions.assertTrue(InternalClientType.checkValid("HADOOP_GVFS"));
+ Assertions.assertTrue(InternalClientType.checkValid("PYTHON_GVFS"));
+ Assertions.assertTrue(InternalClientType.checkValid("UNKNOWN"));
+ Assertions.assertFalse(InternalClientType.checkValid("NO_SUCH_CLIENT"));
+ Assertions.assertFalse(InternalClientType.checkValid(null));
+ }
+
+ @Test
+ public void testCheckValidWithEmptyString() {
+ Assertions.assertFalse(InternalClientType.checkValid(""));
+ }
+
+ @Test
+ public void testCheckValidWithWhitespace() {
+ Assertions.assertFalse(InternalClientType.checkValid(" "));
+ Assertions.assertFalse(InternalClientType.checkValid(" HADOOP_GVFS "));
+ }
+
+ @Test
+ public void testCheckValidWithCaseSensitivity() {
+ Assertions.assertFalse(InternalClientType.checkValid("hadoop_gvfs"));
+ Assertions.assertFalse(InternalClientType.checkValid("Hadoop_Gvfs"));
+ }
+}
