jerryshao commented on code in PR #7850:
URL: https://github.com/apache/gravitino/pull/7850#discussion_r2269701581
##########
core/src/main/java/org/apache/gravitino/stats/storage/PartitionStatisticStorage.java:
##########
@@ -86,34 +73,13 @@ void dropStatistics(
String metalake, List<MetadataObjectStatisticsDrop>
partitionStatisticsToDrop);
/**
- * Updates statistics for a given metadata object. The default
implementation is to first drop and
- * then append the statistics. Developer can override this logic if needed.
The implementation
- * should guarantee the thread safe. The upper layer will add the parent
object level write lock.
- * For example, if the metadata object is a table, the write lock of the
schema level will be
- * held.
+ * Updates statistics for a given metadata object. The implementation should
guarantee the thread
+ * safe. The upper layer will add the parent object level write lock. For
example, if the metadata
+ * object is a table, the write lock of the schema level will be held.
Review Comment:
You should describe the behavior, is it pure update, or upsert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
