jerryshao commented on code in PR #7794:
URL: https://github.com/apache/gravitino/pull/7794#discussion_r2269309728
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/DefaultGVFSOperations.java:
##########
@@ -63,6 +63,9 @@ public FSDataInputStream open(Path gvfsPath, int bufferSize)
throws IOException
FileSystem actualFs = getActualFileSystem(gvfsPath, currentLocationName());
Path actualFilePath =
getActualFilePath(gvfsPath, currentLocationName(),
FilesetDataOperation.OPEN);
+ if (actualFs.exists(actualFilePath) &&
!actualFs.getFileStatus(actualFilePath).isFile()) {
Review Comment:
I think wrong operation will be failed finally, we don't have to do the
strict check beforehand. My concern is like @yuqi1129 mentioned, we should not
rely on the path to do the strict check, because the behavior of different
storages are different (and we don't know the expected behavior). We don't have
to the over-check, we can let the underlying storage to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
