diqiu50 commented on code in PR #8022:
URL: https://github.com/apache/gravitino/pull/8022#discussion_r2268414248
##########
api/src/main/java/org/apache/gravitino/stats/StatisticValues.java:
##########
@@ -291,7 +292,7 @@ public static class ObjectValue implements
StatisticValue<Map<String, StatisticV
private ObjectValue(Map<String, StatisticValue<?>> valueMap) {
Preconditions.checkArgument(
valueMap != null && !valueMap.isEmpty(), "Values cannot be null or
empty");
- this.valueMap = valueMap;
+ this.valueMap = new TreeMap<>(valueMap);
Review Comment:
Should we check whether the passed-in map is a TreeMap before copying?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
