yuqi1129 commented on code in PR #7905: URL: https://github.com/apache/gravitino/pull/7905#discussion_r2256596862
########## mcp-server/build.gradle.kts: ########## @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.gradle.api.GradleException +import org.gradle.api.tasks.Delete +import org.gradle.api.tasks.Exec +import org.gradle.kotlin.dsl.register +import java.io.File + +val pythonProjectDir = project.projectDir +val venvDir = pythonProjectDir.resolve(".venv") + +val globalUvExecutable = when { + System.getProperty("os.name").contains("win", ignoreCase = true) -> "uv.exe" + else -> "uv" +} + +fun getUvExecutable(): String { + return if (project.extensions.extraProperties.has("uvExecutable")) { + project.extensions.extraProperties.get("uvExecutable") as String + } else { + globalUvExecutable + } +} + +val venvPython = when { + System.getProperty("os.name").contains("win", ignoreCase = true) -> + venvDir.resolve("Scripts/python.exe").absolutePath + else -> + venvDir.resolve("bin/python").absolutePath +} + +tasks { + register<Exec>("installUv") { + group = "python" + description = "Install UV if not present" + + val isWindows = System.getProperty("os.name").contains("win", ignoreCase = true) + val uvInstallDir = file("$pythonProjectDir/.uv/bin").apply { mkdirs() } + val uvExecutable = if (isWindows) { + file("$uvInstallDir/uv.exe") + } else { + file("$uvInstallDir/uv") + } + + onlyIf { + if (uvExecutable.exists()) { + project.extensions.extraProperties.set("uvExecutable", uvExecutable.absolutePath) + logger.lifecycle("UV already installed at: ${uvExecutable.absolutePath}") + false + } else { + try { + exec { + commandLine(globalUvExecutable, "--version") + isIgnoreExitValue = true + }.exitValue != 0 + } catch (e: Exception) { + true + } + } + } + + doFirst { + logger.lifecycle("UV not found, installing via official script...") + } + + if (isWindows) { + commandLine( + "powershell", + "-Command", + "\$env:UV_INSTALL_DIR='${uvInstallDir.absolutePath}'; " + + "irm https://astral.sh/uv/install.ps1 | iex" + ) + } else { + commandLine( + "/bin/sh", + "-c", + "export UV_INSTALL_DIR=${uvInstallDir.absolutePath}; " + + "curl -LsSf https://astral.sh/uv/install.sh | sh" + ) + } + + doLast { + val uvCheck = exec { + commandLine(uvExecutable.absolutePath, "--version") + isIgnoreExitValue = true + } + if (uvCheck.exitValue != 0) { + throw GradleException("UV installation failed") + } + + project.extensions.extraProperties.set("uvExecutable", uvExecutable.absolutePath) + } + } + + register<Exec>("createVenvWithUv") { + group = "python" + description = "Create Python virtual environment using UV" + dependsOn("installUv") + workingDir(pythonProjectDir) + + doFirst { + println("UV executable path: ${getUvExecutable()}") + commandLine(getUvExecutable(), "venv", venvDir.absolutePath) + } + + doLast { + if (executionResult.get().exitValue != 0) { + throw GradleException("Failed to create virtual environment with UV. Exit code: ${executionResult.get().exitValue}") + } + + if (!File(venvPython).exists()) { + throw GradleException("Virtual environment creation failed. Python executable not found at: $venvPython") + } + } + } + + register<Exec>("installDependenciesWithUv") { + group = "python" + description = "Install Python dependencies using global UV" + dependsOn("createVenvWithUv") + workingDir(pythonProjectDir) + + doFirst { + commandLine(getUvExecutable(), "pip", "install", "--python", venvPython, "-e", ".") + } + + doLast { + if (executionResult.get().exitValue != 0) { + throw GradleException("Failed to install dependencies. Exit code: ${executionResult.get().exitValue}") + } + } + } + + register<Exec>("installFormatTools") { + group = "python" + description = "Install code formatting tools" + dependsOn("createVenvWithUv") + workingDir(pythonProjectDir) + + doFirst { + commandLine(getUvExecutable(), "pip", "install", "--python", venvPython, "black", "isort") + } + + doLast { + if (executionResult.get().exitValue != 0) { + throw GradleException("Failed to install formatting tools. Exit code: ${executionResult.get().exitValue}") + } + } + } + + register("buildPython") { + group = "python" + description = "Build Python project" + dependsOn("installDependenciesWithUv") + doLast { + logger.lifecycle("Python project built successfully") + } + } + + register<Exec>("testPython") { + group = "python" + description = "Run Python unit tests with unittest" + dependsOn("buildPython") + workingDir(pythonProjectDir) + + commandLine(venvPython, "-m", "unittest", "discover", "-s", "tests", "-v") + + doLast { + if (executionResult.get().exitValue != 0) { + throw GradleException("Unit tests failed. Exit code: ${executionResult.get().exitValue}") + } + } + } + + register<Delete>("cleanPython") { + group = "python" + description = "Clean Python build artifacts" + delete(venvDir) + delete(pythonProjectDir.resolve(".uv")) + delete(pythonProjectDir.resolve("dist")) + delete(pythonProjectDir.resolve("build")) + delete(pythonProjectDir.resolve("*.egg-info")) + } + + register<DefaultTask>("formatApplyPython") { + group = "python" + description = "Apply Black formatting and isort import sorting" + dependsOn("installFormatTools") + + doLast { + // Apply isort + exec { + workingDir = pythonProjectDir + commandLine(venvPython, "-m", "isort", "mcp_server", "tests") + } + + // Apply Black + exec { + workingDir = pythonProjectDir + commandLine(venvPython, "-m", "black", "mcp_server", "tests") + } + + logger.lifecycle("Python formatting applied (isort + Black)") + } + } + + register<DefaultTask>("formatCheckPython") { + group = "python" + description = "Check Python code formatting with Black and import order with isort" + dependsOn("installFormatTools") + + doLast { + var anyFailed = false + + val isortExitCode = exec { + workingDir = pythonProjectDir + commandLine(venvPython, "-m", "isort", "--check", "mcp_server", "tests") + isIgnoreExitValue = false + }.exitValue + + if (isortExitCode != 0) { + throw GradleException("Python isort formatting check failed") + } + + val blackExitCode = exec { + workingDir = pythonProjectDir + commandLine(venvPython, "-m", "black", "--check", "mcp_server", "tests") + isIgnoreExitValue = false + }.exitValue + + if (blackExitCode != 0) { + throw GradleException("Python black formatting check failed") + anyFailed = true Review Comment: `anyFailed = true` anyFailed is never used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
