hqbhoho commented on code in PR #7907: URL: https://github.com/apache/gravitino/pull/7907#discussion_r2251566596
########## docs/trino-connector/supported-catalog.md: ########## @@ -137,6 +137,7 @@ call gravitino.system.create_catalog( ``` A prefix with `trino.bypass.` in the configuration key is used to indicate Gravitino Trino connector to pass the Trino connector configuration to the Gravitino catalog in the Trino runtime. +Note that it is when a configuration property is explicitly defined in Gravitino that the `trino.bypass.`properties which for the same property will be skipped. Review Comment: For example, the Trino MySQL connector properties `connection-url`, `connection-user` and `connection-password` inherit values directly from the `jdbc-url`, `jdbc-user` and `jdbc-password` defined in the Gravitino MySQL catalog. As a result, these configurations cannot be overridden by any `trino.bypass.*` properties. Maybe we can add an example or we list the configuration which should not defined by `trino.bypass.*` properties? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
