yuqi1129 commented on code in PR #7923:
URL: https://github.com/apache/gravitino/pull/7923#discussion_r2251458715
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -399,6 +403,16 @@ public GravitinoAuthorizer gravitinoAuthorizer() {
return gravitinoAuthorizer;
}
+ /**
+ * Get the AuditLogManager associated with the Gravitino environment.
Review Comment:
AuditLogManager -> JobOperationDispatcher
##########
server/src/main/java/org/apache/gravitino/server/web/rest/JobOperations.java:
##########
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.server.web.rest;
+
+import com.codahale.metrics.annotation.ResponseMetered;
+import com.codahale.metrics.annotation.Timed;
+import com.google.common.annotations.VisibleForTesting;
+import java.time.Instant;
+import java.util.List;
+import java.util.stream.Collectors;
+import javax.inject.Inject;
+import javax.servlet.http.HttpServletRequest;
+import javax.ws.rs.DELETE;
+import javax.ws.rs.DefaultValue;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.QueryParam;
+import javax.ws.rs.core.Context;
+import javax.ws.rs.core.Response;
+import org.apache.gravitino.GravitinoEnv;
+import org.apache.gravitino.dto.job.JobTemplateDTO;
+import org.apache.gravitino.dto.job.ShellJobTemplateDTO;
+import org.apache.gravitino.dto.job.SparkJobTemplateDTO;
+import org.apache.gravitino.dto.requests.JobTemplateRegisterRequest;
+import org.apache.gravitino.dto.responses.BaseResponse;
+import org.apache.gravitino.dto.responses.DropResponse;
+import org.apache.gravitino.dto.responses.JobTemplateListResponse;
+import org.apache.gravitino.dto.responses.JobTemplateResponse;
+import org.apache.gravitino.dto.responses.NameListResponse;
+import org.apache.gravitino.dto.util.DTOConverters;
+import org.apache.gravitino.job.JobOperationDispatcher;
+import org.apache.gravitino.meta.AuditInfo;
+import org.apache.gravitino.meta.JobTemplateEntity;
+import org.apache.gravitino.metrics.MetricNames;
+import org.apache.gravitino.server.web.Utils;
+import org.apache.gravitino.utils.NamespaceUtil;
+import org.apache.gravitino.utils.PrincipalUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Path("metalakes/{metalake}/jobs")
+public class JobOperations {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(JobOperations.class);
+
+ private final JobOperationDispatcher jobOperationDispatcher;
+
+ @Context HttpServletRequest httpRequest;
+
+ @Inject
+ public JobOperations(JobOperationDispatcher jobOperationDispatcher) {
+ this.jobOperationDispatcher = jobOperationDispatcher;
+ }
+
+ @GET
+ @Path("templates")
+ @Produces("application/vnd.gravitino.v1+json")
+ @Timed(name = "list-job-templates." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "list-job-templates", absolute = true)
+ public Response listJobTemplates(
+ @PathParam("metalake") String metalake,
+ @QueryParam("details") @DefaultValue("false") boolean details) {
+ LOG.info(
+ "Received request to list job templates in metalake: {}, details: {}",
metalake, details);
+
+ try {
+ return Utils.doAs(
+ httpRequest,
+ () -> {
+ List<JobTemplateDTO> jobTemplates =
+ toDTOs(jobOperationDispatcher.listJobTemplates(metalake));
+ if (details) {
+ LOG.info("List {} job templates in metalake: {}",
jobTemplates.size(), metalake);
+ return Utils.ok(new JobTemplateListResponse(jobTemplates));
+
+ } else {
+ String[] jobTemplateNames =
+
jobTemplates.stream().map(JobTemplateDTO::name).toArray(String[]::new);
+
+ LOG.info(
+ "List {} job template names in metalake: {}",
jobTemplateNames.length, metalake);
+ return Utils.ok(new NameListResponse(jobTemplateNames));
+ }
+ });
+
+ } catch (Exception e) {
+ LOG.error("Error listing job templates in metalake: {}", metalake, e);
+ return ExceptionHandlers.handleJobTemplateException(OperationType.LIST,
"", metalake, e);
+ }
+ }
+
+ @POST
+ @Path("templates")
+ @Produces("application/vnd.gravitino.v1+json")
+ @Timed(name = "register-job-template." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "register-job-template", absolute = true)
+ public Response registerJobTemplate(
+ @PathParam("metalake") String metalake, JobTemplateRegisterRequest
request) {
+ LOG.info("Received request to register job template in metalake: {}",
metalake);
+
+ try {
+ return Utils.doAs(
+ httpRequest,
+ () -> {
+ request.validate();
+
+ jobOperationDispatcher.registerJobTemplate(
+ metalake, toEntity(metalake, request.getJobTemplate()));
+
+ LOG.info(
+ "Registered job template {} in metalake: {}",
+ request.getJobTemplate().name(),
+ metalake);
+ return Utils.ok(new BaseResponse());
+ });
+
+ } catch (Exception e) {
+ LOG.error(
+ "Error registering job template: {} in metalake: {}",
+ request.getJobTemplate().name(),
+ metalake,
+ e);
+ return ExceptionHandlers.handleJobTemplateException(
+ OperationType.REGISTER, request.getJobTemplate().name(), metalake,
e);
+ }
+ }
+
+ @GET
+ @Path("templates/{name}")
+ @Produces("application/vnd.gravitino.v1+json")
+ @Timed(name = "get-job-template." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "get-job-template", absolute = true)
+ public Response getJobTemplate(
+ @PathParam("metalake") String metalake, @PathParam("name") String name) {
+ LOG.info("Received request to get job template: {} in metalake: {}", name,
metalake);
+
+ try {
+ return Utils.doAs(
+ httpRequest,
+ () -> {
+ JobTemplateEntity jobTemplateEntity =
+ jobOperationDispatcher.getJobTemplate(metalake, name);
+
+ LOG.info("Retrieved job template {} in metalake: {}", name,
metalake);
+ return Utils.ok(new JobTemplateResponse(toDTO(jobTemplateEntity)));
Review Comment:
Are there any modification options for job templates available?
##########
server/src/main/java/org/apache/gravitino/server/web/rest/JobOperations.java:
##########
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.server.web.rest;
+
+import com.codahale.metrics.annotation.ResponseMetered;
+import com.codahale.metrics.annotation.Timed;
+import com.google.common.annotations.VisibleForTesting;
+import java.time.Instant;
+import java.util.List;
+import java.util.stream.Collectors;
+import javax.inject.Inject;
+import javax.servlet.http.HttpServletRequest;
+import javax.ws.rs.DELETE;
+import javax.ws.rs.DefaultValue;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.QueryParam;
+import javax.ws.rs.core.Context;
+import javax.ws.rs.core.Response;
+import org.apache.gravitino.GravitinoEnv;
+import org.apache.gravitino.dto.job.JobTemplateDTO;
+import org.apache.gravitino.dto.job.ShellJobTemplateDTO;
+import org.apache.gravitino.dto.job.SparkJobTemplateDTO;
+import org.apache.gravitino.dto.requests.JobTemplateRegisterRequest;
+import org.apache.gravitino.dto.responses.BaseResponse;
+import org.apache.gravitino.dto.responses.DropResponse;
+import org.apache.gravitino.dto.responses.JobTemplateListResponse;
+import org.apache.gravitino.dto.responses.JobTemplateResponse;
+import org.apache.gravitino.dto.responses.NameListResponse;
+import org.apache.gravitino.dto.util.DTOConverters;
+import org.apache.gravitino.job.JobOperationDispatcher;
+import org.apache.gravitino.meta.AuditInfo;
+import org.apache.gravitino.meta.JobTemplateEntity;
+import org.apache.gravitino.metrics.MetricNames;
+import org.apache.gravitino.server.web.Utils;
+import org.apache.gravitino.utils.NamespaceUtil;
+import org.apache.gravitino.utils.PrincipalUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Path("metalakes/{metalake}/jobs")
+public class JobOperations {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(JobOperations.class);
+
+ private final JobOperationDispatcher jobOperationDispatcher;
+
+ @Context HttpServletRequest httpRequest;
+
+ @Inject
+ public JobOperations(JobOperationDispatcher jobOperationDispatcher) {
+ this.jobOperationDispatcher = jobOperationDispatcher;
+ }
+
+ @GET
+ @Path("templates")
+ @Produces("application/vnd.gravitino.v1+json")
+ @Timed(name = "list-job-templates." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "list-job-templates", absolute = true)
+ public Response listJobTemplates(
+ @PathParam("metalake") String metalake,
+ @QueryParam("details") @DefaultValue("false") boolean details) {
+ LOG.info(
+ "Received request to list job templates in metalake: {}, details: {}",
metalake, details);
+
+ try {
+ return Utils.doAs(
+ httpRequest,
+ () -> {
+ List<JobTemplateDTO> jobTemplates =
+ toDTOs(jobOperationDispatcher.listJobTemplates(metalake));
+ if (details) {
+ LOG.info("List {} job templates in metalake: {}",
jobTemplates.size(), metalake);
+ return Utils.ok(new JobTemplateListResponse(jobTemplates));
+
+ } else {
+ String[] jobTemplateNames =
+
jobTemplates.stream().map(JobTemplateDTO::name).toArray(String[]::new);
+
+ LOG.info(
+ "List {} job template names in metalake: {}",
jobTemplateNames.length, metalake);
+ return Utils.ok(new NameListResponse(jobTemplateNames));
+ }
+ });
+
+ } catch (Exception e) {
+ LOG.error("Error listing job templates in metalake: {}", metalake, e);
+ return ExceptionHandlers.handleJobTemplateException(OperationType.LIST,
"", metalake, e);
+ }
+ }
+
+ @POST
+ @Path("templates")
+ @Produces("application/vnd.gravitino.v1+json")
+ @Timed(name = "register-job-template." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "register-job-template", absolute = true)
+ public Response registerJobTemplate(
+ @PathParam("metalake") String metalake, JobTemplateRegisterRequest
request) {
+ LOG.info("Received request to register job template in metalake: {}",
metalake);
+
+ try {
+ return Utils.doAs(
+ httpRequest,
+ () -> {
+ request.validate();
+
+ jobOperationDispatcher.registerJobTemplate(
+ metalake, toEntity(metalake, request.getJobTemplate()));
+
+ LOG.info(
+ "Registered job template {} in metalake: {}",
+ request.getJobTemplate().name(),
+ metalake);
+ return Utils.ok(new BaseResponse());
+ });
+
+ } catch (Exception e) {
+ LOG.error(
+ "Error registering job template: {} in metalake: {}",
+ request.getJobTemplate().name(),
+ metalake,
+ e);
+ return ExceptionHandlers.handleJobTemplateException(
+ OperationType.REGISTER, request.getJobTemplate().name(), metalake,
e);
+ }
+ }
+
+ @GET
+ @Path("templates/{name}")
+ @Produces("application/vnd.gravitino.v1+json")
+ @Timed(name = "get-job-template." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "get-job-template", absolute = true)
+ public Response getJobTemplate(
+ @PathParam("metalake") String metalake, @PathParam("name") String name) {
+ LOG.info("Received request to get job template: {} in metalake: {}", name,
metalake);
+
+ try {
+ return Utils.doAs(
+ httpRequest,
+ () -> {
+ JobTemplateEntity jobTemplateEntity =
+ jobOperationDispatcher.getJobTemplate(metalake, name);
+
+ LOG.info("Retrieved job template {} in metalake: {}", name,
metalake);
+ return Utils.ok(new JobTemplateResponse(toDTO(jobTemplateEntity)));
+ });
+
+ } catch (Exception e) {
+ LOG.error("Error getting job template: {} in metalake: {}", name,
metalake, e);
+ return ExceptionHandlers.handleJobTemplateException(OperationType.GET,
name, metalake, e);
+ }
+ }
+
+ @DELETE
+ @Path("templates/{name}")
+ @Produces("application/vnd.gravitino.v1+json")
+ @Timed(name = "delete-job-template." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "delete-job-template", absolute = true)
+ public Response deleteJobTemplate(
+ @PathParam("metalake") String metalake, @PathParam("name") String name) {
+ LOG.info("Received request to delete job template: {} in metalake: {}",
name, metalake);
+
+ try {
+ return Utils.doAs(
+ httpRequest,
+ () -> {
+ boolean deleted =
jobOperationDispatcher.deleteJobTemplate(metalake, name);
+ if (!deleted) {
+ LOG.warn("Failed to delete job template {} in metalake {}",
name, metalake);
Review Comment:
According to the comment on method `deleteJobTemplate`, `false` means the
template does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
