georgereuben commented on PR #7755:
URL: https://github.com/apache/gravitino/pull/7755#issuecomment-3111731040

   > @georgereuben Is this PR ready for review?
   
   Yes, I was facing issues with the testCheckValue test, so I have made some 
changes to make it work with the new strToSeq behavior.
   
   The original test used a list containing only an empty string [""], which 
   serialized to an empty string "". With the new behavior, strToSeq("") 
   returns an empty list [] instead of [""], so validation never runs.
   
   Changed the test to use ["valid", "", "another"] which serializes to 
   "valid,,another". This still tests validation on empty elements while 
   working with the improved strToSeq behavior.
   
   I have updated the test in the [latest 
commit](https://github.com/apache/gravitino/pull/7755/commits/bd3d3f1b8ea734513fe8d4c08bd3bb89d98b5d49)
 . Let me know if this change looks good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to