predator4ann commented on code in PR #6657:
URL: https://github.com/apache/gravitino/pull/6657#discussion_r2220805826
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/converter/FromIcebergType.java:
##########
@@ -90,13 +92,15 @@ public Type
primitive(org.apache.iceberg.types.Type.PrimitiveType primitive) {
case DATE:
return org.apache.gravitino.rel.types.Types.DateType.get();
case TIME:
- return org.apache.gravitino.rel.types.Types.TimeType.get();
+ return
org.apache.gravitino.rel.types.Types.TimeType.of(PRECISION_MICROSECOND);
Review Comment:
> Iceberg only supports one micro precision? Could you please attach the
relevant document here?
Yes, currently only `microseconds` is supported. Here is the link:
https://iceberg.apache.org/docs/nightly/schemas/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
