yuqi1129 commented on code in PR #7612:
URL: https://github.com/apache/gravitino/pull/7612#discussion_r2193835416
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java:
##########
@@ -110,6 +117,14 @@ public GravitinoTable createTable(ConnectorTableMetadata
tableMetadata) {
toGravitinoTableProperties(
removeKeys(tableMetadata.getProperties(),
ICEBERG_PROPERTIES_TO_REMOVE));
+ if (propertyMap.containsKey(ICEBERG_FORMAT_PROPERTY)) {
+ String format = propertyMap.get(ICEBERG_FORMAT_PROPERTY).toString();
+ properties.put(FORMAT, format);
Review Comment:
I wonder if the value of `PROVIDER` is always not null when the property
`format` is provided.
##########
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/00007_varchar.txt:
##########
@@ -16,6 +16,8 @@ CREATE TABLE
)
COMMENT ''
WITH (
+ format = 'PARQUET',
+ format_version = '2',
Review Comment:
Is the value of `format_version` always '2'? What if Iceberg upgrade the
format to `3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
