unknowntpo commented on code in PR #7582:
URL: https://github.com/apache/gravitino/pull/7582#discussion_r2192209108
##########
clients/client-python/gravitino/dto/rel/expressions/field_reference_dto.py:
##########
@@ -42,3 +42,53 @@ def __eq__(self, other: object) -> bool:
def __hash__(self) -> int:
return hash((self.arg_type(), tuple(self._field_name)))
+
+ @staticmethod
+ def builder() -> Builder:
+ """The builder for creating a new instance of `FieldReferenceDTO`.
+
+ Returns:
+ Builder: The builder for creating a new instance of
`FieldReferenceDTO`.
+ """
+ return FieldReferenceDTO.Builder()
+
+ class Builder:
+ """Builder for `FieldRererenceDTO`"""
+
+ def __init__(self):
+ self._field_name = None
+
+ def with_field_name(self, field_name: List[str]) ->
FieldReferenceDTO.Builder:
+ """Set the field name for the field reference.
+
+ Args:
+ field_name (List[str]): The field name.
+
+ Returns:
+ FieldReferenceDTO.Builder: The builder.
+ """
+
+ self._field_name = field_name
+ return self
+
+ def with_column_name(self, column_name: List[str]) ->
FieldReferenceDTO.Builder:
+ """Set the column name for the field reference.
+
+ Args:
+ column_name (List[str]): The column name.
+
+ Returns:
+ FieldReferenceDTO.Builder: The builder.
+ """
+
+ self._field_name = column_name
Review Comment:
Why does `with_column_name` share same variable `self._field_name` as
`with_field_name` ? Is this intended ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
