jerqi commented on code in PR #7605:
URL: https://github.com/apache/gravitino/pull/7605#discussion_r2191565574
##########
server/src/main/java/org/apache/gravitino/server/web/rest/ModelOperations.java:
##########
@@ -516,11 +666,20 @@ public Response alterModelVersionByAlias(
@Produces("application/vnd.gravitino.v1+json")
@Timed(name = "alter-model." + MetricNames.HTTP_PROCESS_DURATION, absolute =
true)
@ResponseMetered(name = "alter-model", absolute = true)
+ @AuthorizationExpression(
+ expression =
+ "ANY(OWNER,METALAKE,CATALOG,SCHEMA) || "
Review Comment:
SchemaOwner should have privilege `use catalog`.
##########
server/src/main/java/org/apache/gravitino/server/web/rest/ModelOperations.java:
##########
@@ -471,11 +612,20 @@ public Response alterModelVersion(
@Produces("application/vnd.gravitino.v1+json")
@Timed(name = "alter-model-alias." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
@ResponseMetered(name = "alter-model-alias", absolute = true)
+ @AuthorizationExpression(
+ expression =
+ "ANY(OWNER,METALAKE,CATALOG) || "
Review Comment:
Could you give a proper blank to the expression?
```
ANY(OWNER, METALAKE, CATALOG)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]