senlizishi commented on code in PR #7544:
URL: https://github.com/apache/gravitino/pull/7544#discussion_r2181561594
##########
core/src/test/java/org/apache/gravitino/TestStringIdentifier.java:
##########
@@ -163,6 +163,10 @@ public void testGetStringIdFromComment() {
String comment1 = "This is a comment";
StringIdentifier stringIdFromComment2 =
StringIdentifier.fromComment(comment1);
Assertions.assertNull(stringIdFromComment2);
+
+ // Test comment contains parentheses but not the Gravitino prefix
+ String comment2 = "A comment (other info)";
+ Assertions.assertNull(StringIdentifier.fromComment(comment2));
}
Review Comment:
Hi @jerryshao I have adjusted the code logic and added tests to cover my
adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
