FANNG1 commented on PR #7418: URL: https://github.com/apache/gravitino/pull/7418#issuecomment-3018776994
> > > Using name `modern` is weird; you'd better use a more meaningful name. Also, can you support JDK 11+ with Iceberg 1.6? As far as I understand, I think we should support JDK 8+ with Iceberg 1.6, JDK 11+ with Iceberg 1.9, right? > > > We can use something like conditional compile by specifying using which iceberg version to compile, like `gradle build -PicebergVersion=xxx`, if user chooses Iceberg 1.9, then we choose the higher version of JDK. > > > > > > How about using `UsingNewIceberg` to control whether using new Iceberg version to compile Gravitino like `gradlew compileDistribution -PusingNewIceberg=true`? internally we could add the validate check logic for JDK. > > Can you explain more of how to use this new property? Please show me a support matrix with different JDK versions plus Iceberg versions. `usingNewIceberg` is `false` by default, we could compile Iceberg modules with Iceberg 1.6 and all JDKs. If setting `usingNewIceberg` to `true`, the Iceberg modules (including IRC and Iceberg catalog) are compiled with Iceberg 1.9 and can only be compiled by JDK 11 or 17. | usingNewIceberg | supported JDK Version | supported Iceberg version | |--------------------------------------|--------------------------------------|------------------| | `true` | 11,17 | 1.9 | | `false` | 8,11,17 | 1.6 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
