Abyss-lord commented on code in PR #7459:
URL: https://github.com/apache/gravitino/pull/7459#discussion_r2168274094
##########
core/src/main/java/org/apache/gravitino/metalake/MetalakeManager.java:
##########
@@ -103,13 +79,6 @@ public void close() {
public MetalakeManager(EntityStore store, IdGenerator idGenerator) {
this.store = store;
this.idGenerator = idGenerator;
-
- // pre-load all metalakes and put them into cache, this is useful when
user load schema/table
- // directly without list/get metalake first.
- BaseMetalake[] metalakes = listMetalakes();
- for (BaseMetalake metalake : metalakes) {
- METALAKE_CACHE.put(metalake.nameIdentifier(), metalake);
- }
Review Comment:
If we want to cache all Metalakes during initialization, we would need to
modify the list method in the cache layer.
Currently, `EntityCache#list` does not perform any caching operation—it
simply delegates to the underlying store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
