FANNG1 commented on PR #7444:
URL: https://github.com/apache/gravitino/pull/7444#issuecomment-3006683984

   The ci failed because we pass the warehouse location to the `warehouse` for 
REST catalog,  this is not correct, 
   
https://github.com/apache/gravitino/blob/f84361e78f7cae5885ac7de05ef4eb247b391c81/catalogs/catalog-lakehouse-iceberg/src/test/java/org/apache/gravitino/catalog/lakehouse/iceberg/integration/test/CatalogIcebergBaseIT.java#L215
   
   may be we could improve like this:
   ```java
      if (!"rest".equalsIgnoreCase(TYPE)) {
         catalogProperties.put(IcebergConfig.CATALOG_WAREHOUSE.getKey(), 
WAREHOUSE);
       }
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to