Abyss-lord commented on code in PR #7471:
URL: https://github.com/apache/gravitino/pull/7471#discussion_r2166109451


##########
build.gradle.kts:
##########
@@ -819,7 +819,11 @@ tasks {
         it.name != "trino-connector" &&
         it.parent?.name != "bundles"
       ) {
-        from(it.configurations.runtimeClasspath)
+        from(
+          project.files(it.configurations.runtimeClasspath).filter { file ->
+            !file.name.contains("jcstress", ignoreCase = true)
+          }
+        )

Review Comment:
   > Do we need this change, I think the below change should be enough?
   
   Thanks for the reminder!  — the change below should be sufficient since the 
jcstress artifacts are not part of the runtimeClasspath by default.



##########
build.gradle.kts:
##########
@@ -819,7 +819,11 @@ tasks {
         it.name != "trino-connector" &&
         it.parent?.name != "bundles"
       ) {
-        from(it.configurations.runtimeClasspath)
+        from(
+          project.files(it.configurations.runtimeClasspath).filter { file ->
+            !file.name.contains("jcstress", ignoreCase = true)
+          }
+        )

Review Comment:
   > Do we need this change, I think the below change should be enough?
   
   Fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to