jerryshao commented on code in PR #7386:
URL: https://github.com/apache/gravitino/pull/7386#discussion_r2160676657
##########
catalogs/catalog-model/src/main/java/org/apache/gravitino/catalog/model/ModelPropertiesMetadata.java:
##########
@@ -27,6 +29,15 @@ public class ModelPropertiesMetadata extends
BasePropertiesMetadata {
@Override
protected Map<String, PropertyEntry<?>> specificPropertyEntries() {
- return Collections.emptyMap();
+ return ImmutableMap.<String, PropertyEntry<?>>builder()
+ .put(
+ PROPERTY_DEFAULT_URI_NAME,
+ PropertyEntry.stringOptionalPropertyEntry(
+ PROPERTY_DEFAULT_URI_NAME,
+ "The default URI name for the versions of the model",
+ false /* immutable */,
+ null,
+ false /* hidden */))
+ .build();
Review Comment:
We'd better create a class level variable to maintain the properties, so we
don't have to create the map each time when we call this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
