Abyss-lord commented on code in PR #7330: URL: https://github.com/apache/gravitino/pull/7330#discussion_r2151258589
########## core/src/main/java/org/apache/gravitino/cache/provider/CacheProvider.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cache.provider; + +import org.apache.gravitino.Config; +import org.apache.gravitino.cache.EntityCache; + +/** + * Interface CacheProvider defines the standard methods for a cache provider to obtain cache + * instances. + */ +public interface CacheProvider { + + /** + * Gets the name of the cache provider. + * + * @return The name of the cache provider. + */ + String name(); + + /** + * Gets a {@link EntityCache} instance based on the cache configuration. + * + * @param config The configuration for the cache. + * @return A cache instance initialized according to the configuration. + */ + EntityCache getCache(Config config); +} Review Comment: Fix. I remove this interface and avoid using SPI. Instead, i directly instantiate the specific implementation via reflection based on configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
