KyleLin0927 commented on code in PR #7347:
URL: https://github.com/apache/gravitino/pull/7347#discussion_r2133675831
##########
catalogs/catalog-model/src/main/java/org/apache/gravitino/catalog/model/ModelCatalogOperations.java:
##########
@@ -242,8 +242,7 @@ public void linkModelVersion(
} catch (IOException e) {
throw new RuntimeException("Failed to link model version " + ident, e);
} catch (EntityAlreadyExistsException e) {
- throw new ModelVersionAliasesAlreadyExistException(
- e, "Model version aliases %s already exist", ident);
+ throw new ModelVersionAliasesAlreadyExistException(e, "Model version
alias already exists");
Review Comment:
thanks for suggest. I initially used `modelVersion.aliases()` to show all
aliases in the error message, but it listed all added aliases, not just the
duplicate one.
I suggest simplifying the message to: `Model version alias already exists in
model %s`. This keeps message clear without giving misleading details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
