jerryshao commented on code in PR #7325:
URL: https://github.com/apache/gravitino/pull/7325#discussion_r2127052173
##########
common/src/main/java/org/apache/gravitino/dto/responses/ModelVersionListResponse.java:
##########
@@ -31,14 +32,14 @@
public class ModelVersionListResponse extends BaseResponse {
@JsonProperty("versions")
Review Comment:
We're using same json key `versions` for both `modelVersionListResponse` and
`modelVersionNumberListResponse`. I'm afraid some deserialization methods will
be confused when deserializing from JSON, which class should we call?
Also, it may introduce the compatibility issue. For example, if someone uses
REST APIs and they already uses `versions`, now `versions` has another meaning,
how do they differentiate?
I would suggest to use a different name like "infos", what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
