Abyss-lord commented on code in PR #7330:
URL: https://github.com/apache/gravitino/pull/7330#discussion_r2126537999
##########
core/src/main/java/org/apache/gravitino/cache/CaffeineEntityCache.java:
##########
@@ -137,7 +137,10 @@ private CaffeineEntityCache(Config cacheConfig,
EntityStore entityStore) {
/** {@inheritDoc} */
@Override
public <E extends Entity & HasIdentifier> List<E> getOrLoad(
- NameIdentifier ident, Entity.EntityType type,
SupportsRelationOperations.Type relType)
+ NameIdentifier ident,
+ Entity.EntityType type,
+ SupportsRelationOperations.Type relType,
Review Comment:
Yes, this parameter is necessary. In the context of
`listEntitiesByRelation`, we need to fetch entities that are related to the
given one, and passing true the method will fetch all the fields, Otherwise,
the method will fetch all the fields except for high-cost fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
