predator4ann commented on code in PR #6657:
URL: https://github.com/apache/gravitino/pull/6657#discussion_r2123231978


##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -795,4 +795,14 @@ protected Distribution getDistributionInfo(
       return DorisUtils.extractDistributionInfoFromSql(createTableSyntax);
     }
   }
+
+  @Override
+  public Integer calculateDatetimePrecision(String typeName, int columnSize, 
int scale) {
+    String upperTypeName = typeName.toUpperCase();
+    if (upperTypeName.equals("DATETIME")) {
+      // DATETIME format: 'YYYY-MM-DD HH:MM:SS' (19 chars) + decimal point + 
precision
+      return columnSize >= 20 ? columnSize - 20 : 0;

Review Comment:
   fine



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to