jerryshao commented on code in PR #6891:
URL: https://github.com/apache/gravitino/pull/6891#discussion_r2041366002
##########
lineage/build.gradle.kts:
##########
@@ -24,6 +24,7 @@ plugins {
dependencies {
implementation(project(":common"))
implementation(project(":core"))
+ implementation(project(":common"))
Review Comment:
Why do we write this line again, as it already appears in line 25.
##########
server-common/build.gradle.kts:
##########
@@ -39,6 +39,9 @@ dependencies {
implementation(libs.bundles.metrics)
implementation(libs.commons.lang3)
implementation(libs.guava)
+ implementation(libs.jackson.datatype.jdk8)
+ implementation(libs.jackson.datatype.jsr310)
+ implementation(libs.jackson.databind)
Review Comment:
If we add the jackson dependencies here in this module, shall we remove them
in Lineage module? Since that module will depend on this module.
##########
core/src/main/java/org/apache/gravitino/listener/EventBus.java:
##########
@@ -47,6 +50,11 @@ public class EventBus {
*/
public EventBus(List<EventListenerPlugin> eventListeners) {
this.eventListeners = eventListeners;
+ this.asyncQueueListeners =
Review Comment:
What's the difference between the `eventListeners` and
`asyncQueueListeners`? Can you explain more why do we need this and how they be
used?
##########
lineage/src/main/java/org/apache/gravitino/lineage/sink/LineageSinkManager.java:
##########
@@ -19,23 +19,88 @@
package org.apache.gravitino.lineage.sink;
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Preconditions;
import io.openlineage.server.OpenLineage.RunEvent;
import java.io.Closeable;
+import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.gravitino.lineage.LineageConfig;
+import org.apache.gravitino.listener.EventBus;
+import org.apache.gravitino.listener.EventListenerManager;
+import org.apache.gravitino.listener.api.event.EventWrapper;
-@SuppressWarnings("unused")
public class LineageSinkManager implements Closeable {
+ private EventBus eventBus;
+ private final EventListenerManager eventListenerManager;
- public void initialize(List<String> sinks, Map<String, String>
LineageConfigs) {}
+ public LineageSinkManager() {
+ this.eventListenerManager = new EventListenerManager();
+ }
+
+ public void initialize(List<String> sinks, Map<String, String>
LineageConfigs) {
+ Map<String, String> eventListenerConfigs =
+ transformToEventListenerConfigs(sinks, LineageConfigs);
+ eventListenerManager.init(eventListenerConfigs);
+ this.eventBus = eventListenerManager.createEventBus();
+ eventListenerManager.start();
+ }
// Checks if the sink queue size surpasses the threshold to avoid
overwhelming lineage sinks.
public boolean isHighWatermark() {
- return false;
+ return eventBus.isHighWatermark();
}
- public void sink(RunEvent runEvent) {}
+ @VisibleForTesting
+ static Map<String, String> transformToEventListenerConfigs(
+ List<String> sinks, Map<String, String> lineageConfigs) {
+ Map<String, String> eventListenerConfigs = new HashMap<>();
+ eventListenerConfigs.putAll(generateEventListenerConfigs(sinks,
lineageConfigs));
+ eventListenerConfigs.putAll(lineageConfigs);
+ return eventListenerConfigs;
+ }
+
+ private static Map<String, String> generateEventListenerConfigs(
+ List<String> sinks, Map<String, String> lineageConfigs) {
+ HashMap eventListenerConfigs = new HashMap();
+ if (sinks.isEmpty()) {
+ return eventListenerConfigs;
+ }
+
+ String queueCapacity =
lineageConfigs.get(LineageConfig.LINEAGE_SINK_QUEUE_CAPACITY);
+ Preconditions.checkArgument(
+ StringUtils.isNotBlank(queueCapacity), "Lineage sink queue capacity is
not set");
+ int capacityPerSink = Integer.valueOf(queueCapacity) / sinks.size();
+
+ eventListenerConfigs.put(
+ EventListenerManager.GRAVITINO_EVENT_LISTENER_NAMES, String.join(",",
sinks));
+ sinks.forEach(
+ sinkName -> {
+ eventListenerConfigs.put(
+ sinkName + "." +
EventListenerManager.GRAVITINO_EVENT_LISTENER_CLASS,
+ LineageSinkEventListener.class.getName());
+ eventListenerConfigs.put(
+ sinkName + "." +
EventListenerManager.GRAVITINO_EVENT_LISTENER_QUEUE_CAPACITY,
+ String.valueOf(capacityPerSink));
+ });
+ return eventListenerConfigs;
Review Comment:
There's some logic between Lineage sink and event listeners, also including
some transform logic, can you add some comments in the code to explain the
details?
##########
lineage/src/test/java/org/apache/gravitino/lineage/sink/TestLineageSinkManager.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.lineage.sink;
+
+import io.openlineage.server.OpenLineage.RunEvent;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import lombok.SneakyThrows;
+import org.apache.gravitino.lineage.LineageConfig;
+import org.apache.gravitino.listener.AsyncQueueListener;
+import org.apache.gravitino.listener.EventBus;
+import org.apache.gravitino.listener.EventListenerManager;
+import org.apache.gravitino.listener.EventListenerPluginWrapper;
+import org.apache.gravitino.listener.api.EventListenerPlugin;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+public class TestLineageSinkManager {
+
+ @SneakyThrows
+ @Test
+ void testLineageSinkManager() {
+ LineageSinkManager lineageSinkManager = new LineageSinkManager();
+ lineageSinkManager.initialize(Arrays.asList("sink1", "sink2"),
getLineageSinkConfig());
+ lineageSinkManager.sink(getEvent());
+ EventBus eventBus = lineageSinkManager.eventBus();
+ List<EventListenerPlugin> listeners = eventBus.getEventListeners();
+ Assertions.assertEquals(2, listeners.size());
+
+ listeners.stream()
+ .forEach(
+ listener -> {
+ Assertions.assertTrue(listener instanceof AsyncQueueListener);
+ AsyncQueueListener asyncQueueListener = (AsyncQueueListener)
listener;
+ List<EventListenerPlugin> internalListeners =
asyncQueueListener.getEventListeners();
+ Assertions.assertEquals(1, internalListeners.size());
+ Assertions.assertTrue(internalListeners.get(0) instanceof
EventListenerPluginWrapper);
+ EventListenerPlugin userListener =
+ ((EventListenerPluginWrapper)
internalListeners.get(0)).getUserEventListener();
+ Assertions.assertTrue(userListener instanceof
LineageSinkEventListener);
+ LineageSink sink = ((LineageSinkEventListener)
userListener).lineageSink();
+ Assertions.assertTrue(sink instanceof LineageSinkForTest);
+ checkLineSink((LineageSinkForTest) sink);
+ });
+ }
+
+ @Test
+ void testTransformToEventListenerConfigs() {
+ Map<String, String> configs =
+ LineageSinkManager.transformToEventListenerConfigs(
+ Arrays.asList("sink1", "sink2"), getLineageSinkConfig());
+
+ Assertions.assertEquals(
+ "sink1,sink2",
configs.get(EventListenerManager.GRAVITINO_EVENT_LISTENER_NAMES));
+
+ Assertions.assertEquals(
+ "500",
+ configs.get("sink1." +
EventListenerManager.GRAVITINO_EVENT_LISTENER_QUEUE_CAPACITY));
+ Assertions.assertEquals(
+ LineageSinkEventListener.class.getName(),
+ configs.get("sink1." +
EventListenerManager.GRAVITINO_EVENT_LISTENER_CLASS));
+ Assertions.assertEquals("sink1", configs.get("sink1.name"));
+ Assertions.assertEquals("a", configs.get("sink1.a"));
+
+ Assertions.assertEquals(
+ "500",
+ configs.get("sink2." +
EventListenerManager.GRAVITINO_EVENT_LISTENER_QUEUE_CAPACITY));
+ Assertions.assertEquals(
+ LineageSinkEventListener.class.getName(),
+ configs.get("sink2." +
EventListenerManager.GRAVITINO_EVENT_LISTENER_CLASS));
+ Assertions.assertEquals("b", configs.get("sink2.a"));
+ }
+
+ private void checkLineSink(LineageSinkForTest sink) {
Review Comment:
Typo "Lineage".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
