mchades commented on code in PR #6884:
URL: https://github.com/apache/gravitino/pull/6884#discussion_r2038700024
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -159,24 +159,28 @@ private Map<String, String>
appendNecessaryProperties(Map<String, String> proper
// If the backend server is less than
DEFAULT_REPLICATION_FACTOR_IN_SERVER_SIDE (3), we need to
// set the property 'replication_num' to 1 explicitly.
if (!resultMap.containsKey(REPLICATION_FACTOR)) {
- // Try to check the number of backend servers.
- String query = "select count(*) from information_schema.backends where
Alive = 'true'";
+ // Try to check the number of backend servers using show backends command
+ String query = "show backends";
Review Comment:
I think the comment should explain "why", not "how".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
