xunliu commented on code in PR #6842: URL: https://github.com/apache/gravitino/pull/6842#discussion_r2034289436
########## server-common/src/main/java/org/apache/gravitino/server/authorization/expression/AuthorizationExpressionExecutor.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.server.authorization.expression; + +import java.util.Map; +import org.apache.gravitino.server.authorization.GravitinoAuthorizer; + +/** Authorization through expressions. */ +public class AuthorizationExpressionExecutor { + + /** + * Use {@link AuthorizationExpressionConverter} to convert the authorization expression into an + * OGNL expression, and then call {@link GravitinoAuthorizer} to perform permission verification. + * + * @param expression authorization expression + */ + public AuthorizationExpressionExecutor(String expression) {} + + public boolean authorize(Map<String, Long> resourceIdMap) { Review Comment: maybe variable name `resourceIds` better `resourceIdMap`? ``` public boolean authorize(Map<String/*metadata name*/, Long/*metadata id*/> resourceIds) { ``` Please add a comment to the authorize function. ########## server-common/src/main/java/org/apache/gravitino/server/http/RequestContext.java: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.server.http; + +/** + * RequestContext is used to store the context information of an HTTP request, including the userId. + */ +public interface RequestContext { + + String getUserId(); + + void setUserId(String userId); Review Comment: @jerqi please help review this, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
