granewang commented on code in PR #6778: URL: https://github.com/apache/gravitino/pull/6778#discussion_r2020457903
########## server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosAuthenticator.java: ########## @@ -171,13 +169,7 @@ private Principal retrievePrincipalFromToken(String serverPrincipal, byte[] clie } // Usually principal names are in the form 'user/instance@REALM' or 'user@REALM'. Review Comment: > OK. You should correct the comment, too. is 'user/instance@REALM' or 'user@REALM' ok for new implement? Thanks for your review,Comment updated. Before the code modification, only the principal in the format of user/instance@REALM would cause the error, while the format of user@REALM would not. After the code modification, neither of them causes the error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org