sunxiaojian commented on code in PR #6773:
URL: https://github.com/apache/gravitino/pull/6773#discussion_r2022036474
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##########
@@ -87,8 +94,10 @@ public Optional<CatalogDescriptor> getCatalog(String
catalogName) throws Catalog
CatalogDescriptor.of(catalogName,
Configuration.fromMap(flinkCatalogProperties));
return Optional.of(descriptor);
} catch (Exception e) {
- LOG.warn("Failed to get the catalog:{}", catalogName, e);
- return Optional.empty();
+ throw new CatalogException(
Review Comment:
Modify it like this?
`throw new CatalogException(String.format("Failed to get the catalog: %s ",
catalogName), e);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
