LauraXia123 commented on code in PR #6748:
URL: https://github.com/apache/gravitino/pull/6748#discussion_r2015821379
##########
web/web/src/app/metalakes/metalake/rightContent/tabsContent/tableView/TableView.js:
##########
@@ -336,7 +336,9 @@ const TableView = () => {
title='Delete'
size='small'
sx={{ color: theme => theme.palette.error.light }}
- onClick={() => handleDelete({ name: row.name, type: row.node,
catalogType: row.type })}
+ onClick={() =>
+ handleDelete({ name: row.name, type: row.node, catalogType:
row.type, inUse: row.inUse === 'true' })
Review Comment:
Even if I check again before drop, there is a possibility of gap, the safest
way to check this behavior is the drop api. If the interface behavior is
unchanged, then this checking again seems less important.
##########
web/web/src/app/metalakes/metalake/rightContent/tabsContent/tableView/TableView.js:
##########
@@ -336,7 +336,9 @@ const TableView = () => {
title='Delete'
size='small'
sx={{ color: theme => theme.palette.error.light }}
- onClick={() => handleDelete({ name: row.name, type: row.node,
catalogType: row.type })}
+ onClick={() =>
+ handleDelete({ name: row.name, type: row.node, catalogType:
row.type, inUse: row.inUse === 'true' })
Review Comment:
Even if I check again before drop, there is a possibility of gap, the safest
way to check this behavior is the drop api. If the api behavior is unchanged,
then this checking again seems less important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
