jerqi commented on code in PR #6698: URL: https://github.com/apache/gravitino/pull/6698#discussion_r2004765672
########## authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java: ########## @@ -31,7 +31,16 @@ public class PathBasedMetadataObject implements AuthorizationMetadataObject { */ public enum Type implements AuthorizationMetadataObject.Type { /** A path is mapped the path of storages like HDFS, S3 etc. */ - PATH(MetadataObject.Type.FILESET); + FILESET_PATH(MetadataObject.Type.FILESET), + /** A path is mapped the path of table storage like Hive. */ + TABLE_PATH(MetadataObject.Type.TABLE), + /** A path is mapped the path of schema storage like Hive. */ + SCHEMA_PATH(MetadataObject.Type.SCHEMA), + /** A path is mapped the path of cluster storage like Hive. */ + CATALOG_PATH(MetadataObject.Type.CATALOG), + /** A path is mapped the path of all cluster storages like Hive. */ + METALAKE_PATH(MetadataObject.Type.METALAKE); Review Comment: Every entity may have locations. So we should have different types for different entities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org