yuqi1129 commented on code in PR #6619:
URL: https://github.com/apache/gravitino/pull/6619#discussion_r1985945470
##########
catalogs/hadoop-common/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemProvider.java:
##########
@@ -65,6 +65,23 @@ public interface FileSystemProvider {
FileSystem getFileSystem(@Nonnull Path path, @Nonnull Map<String, String>
config)
throws IOException;
+ /**
+ * Get the FileSystem instance according to the configuration map and file
path.
+ *
+ * @param config The configuration for the FileSystem instance.
+ * @param path The path to the file system.
+ * @param disableCache Whether to cache the FileSystem instance.
+ * @return The FileSystem instance.
+ * @throws IOException If the FileSystem instance cannot be created.
+ */
+ default FileSystem getFileSystem(
+ @Nonnull Path path, @Nonnull Map<String, String> config, boolean
disableCache)
+ throws IOException {
+ // disable cache
+ config.put(String.format("fs.%s.impl.disable.cache", scheme()),
String.valueOf(disableCache));
Review Comment:
What if the config already contains key `fs.%s.impl.disable.cache`? will we
cover it?
##########
catalogs/hadoop-common/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemProvider.java:
##########
@@ -65,6 +65,23 @@ public interface FileSystemProvider {
FileSystem getFileSystem(@Nonnull Path path, @Nonnull Map<String, String>
config)
throws IOException;
+ /**
+ * Get the FileSystem instance according to the configuration map and file
path.
+ *
+ * @param config The configuration for the FileSystem instance.
+ * @param path The path to the file system.
+ * @param disableCache Whether to cache the FileSystem instance.
+ * @return The FileSystem instance.
+ * @throws IOException If the FileSystem instance cannot be created.
+ */
+ default FileSystem getFileSystem(
Review Comment:
Will this method only be used by the Gravitino server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
