AndreVale69 opened a new issue, #6598:
URL: https://github.com/apache/gravitino/issues/6598
### What would you like to be improved?
While working on issue #6577, I noticed (thanks to @yuqi1129, PR #6581) that
there are some inconsistencies between APIs written on Python and Java. I think
that this inconsistency can lead to confusion and errors.
I would like to suggest to adjust the signature functions written on Python.
Here is an approximate list of incosisntecy that I found:
- On the gravitino client you can see the `create_catalog` method:
https://github.com/apache/gravitino/blob/873c6afeb3b0a5ebdb6d64b1d279442ac5e3115c/clients/client-python/gravitino/client/gravitino_client.py#L77-L87
https://github.com/apache/gravitino/blob/873c6afeb3b0a5ebdb6d64b1d279442ac5e3115c/clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java#L118-L127
Or the same with `load_catalog`:
https://github.com/apache/gravitino/blob/873c6afeb3b0a5ebdb6d64b1d279442ac5e3115c/clients/client-python/gravitino/client/gravitino_client.py#L74-L75
https://github.com/apache/gravitino/blob/873c6afeb3b0a5ebdb6d64b1d279442ac5e3115c/clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java#L113-L116
- On metalake you can see the same problem:
https://github.com/apache/gravitino/blob/873c6afeb3b0a5ebdb6d64b1d279442ac5e3115c/clients/client-python/gravitino/client/gravitino_metalake.py#L118-L125
https://github.com/apache/gravitino/blob/873c6afeb3b0a5ebdb6d64b1d279442ac5e3115c/clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoMetalake.java#L215-L222
I'm a new contributor to this repository (I only made a one-line commit), so
if you have any suggestions, I'm ready to hear them!
### How should we improve?
I suggest adapting the function signatures in the Python client to match
those in the Java client. I think this will improve consistency and reduce
potential bugs.
I would like to take up this issue and work on resolving it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
