tengqm commented on code in PR #6574:
URL: https://github.com/apache/gravitino/pull/6574#discussion_r1976859832
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/CommonMetaService.java:
##########
@@ -36,25 +40,47 @@ public Long getParentEntityIdByNamespace(Namespace
namespace) {
Preconditions.checkArgument(
!namespace.isEmpty() && namespace.levels().length <= 3,
"Namespace should not be empty and length should be less than or equal
to 3.");
+
Long parentEntityId = null;
- if (namespace.levels().length >= 1) {
+ if (namespace.levels().length == 1) {
Review Comment:
I can get the optimization logic here.
Can we further revise this logic into a `switch...case` for clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
