zzzk1 commented on code in PR #6540:
URL: https://github.com/apache/gravitino/pull/6540#discussion_r1971766838
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/CatalogMetaService.java:
##########
@@ -119,12 +120,26 @@ public CatalogEntity
getCatalogByIdentifier(NameIdentifier identifier) {
public List<CatalogEntity> listCatalogsByNamespace(Namespace namespace) {
NamespaceUtil.checkCatalog(namespace);
+ List<CatalogPO> catalogPOS = Collections.emptyList();
+ if (namespace.levels().length >= 1) {
+ catalogPOS =
+ SessionUtils.getWithoutCommit(
+ CatalogMetaMapper.class,
+ mapper ->
mapper.listCatalogPOsByMetalakeName(namespace.level(0)));
+ }
+ if (namespace.levels().length >= 2) {
+ catalogPOS =
+ SessionUtils.getWithoutCommit(
+ CatalogMetaMapper.class,
+ mapper ->
mapper.listCatalogPOsByCatalogName(namespace.level(1)));
+ }
- Long metalakeId =
CommonMetaService.getInstance().getParentEntityIdByNamespace(namespace);
-
- List<CatalogPO> catalogPOS =
- SessionUtils.getWithoutCommit(
- CatalogMetaMapper.class, mapper ->
mapper.listCatalogPOsByMetalakeId(metalakeId));
+ if (namespace.levels().length >= 3) {
+ catalogPOS =
+ SessionUtils.getWithoutCommit(
+ CatalogMetaMapper.class,
+ mapper -> mapper.listCatalogPOsBySchemaName(namespace.level(2)));
+ }
Review Comment:
Mistakes here right？metalake has many catalogs, catalog has many schema.
level-1 needs `metalake name` `catalog name`, level-2 needs `metalake name`
`catalog name` `schema name`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
