Abyss-lord commented on code in PR #6495:
URL: https://github.com/apache/gravitino/pull/6495#discussion_r1967766920
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/TableFormat.java:
##########
@@ -540,4 +550,97 @@ public String getOutput(Catalog[] catalogs) {
return getTableFormat(columnName);
}
}
+
+ /**
+ * Formats a single {@link Schema} instance into a two-column table display.
Displays catalog
+ * details including name and comment information.
+ */
+ static final class SchemaTableFormat extends TableFormat<Schema> {
+ public SchemaTableFormat(CommandContext context) {
+ super(context);
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public String getOutput(Schema schema) {
Review Comment:
> If you can invoke the function from the parent class, which is more
generic, then you don't have to create a specialized class to invoke the
`getOutput` method.
>
> I mean this:
>
> ```
> class Animal {
> public describe() {
> legs = getLegs()
> wings = getWings()
> return "legs:" + legs + 'wings:' + wings
> }
> protected getLegs() {
> return 0
> }
> protected getWings() {
> }
> }
>
> class Dog extends Animal {
> protected getLegs() {
> return 4
> }
> }
>
> class Duck extends Animal {
> protected getWings() {
> return 2
> }
> }
> ```
>
> When invoking this method in future, I'll do:
>
> ```
> // I don't need to care what kind of an animal it is.
> animal.describe()
> ```
In this case, the template pattern is used, `BaseOutputFormat#output` is
responsible for output, it fix the logic of output method, and the `getOutput`
method is implemented by subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
