justinmclean commented on code in PR #6483: URL: https://github.com/apache/gravitino/pull/6483#discussion_r1962773409
########## clients/cli/src/main/java/org/apache/gravitino/cli/outputs/BaseOutputFormat.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cli.outputs; + +import com.google.common.base.Preconditions; +import java.io.BufferedOutputStream; +import java.io.IOException; +import java.io.OutputStream; +import java.io.PrintStream; +import java.io.UncheckedIOException; +import java.nio.charset.StandardCharsets; +import org.apache.gravitino.cli.CommandContext; + +/** + * Abstract base implementation of {@link OutputFormat} interface providing common functionality for + * various output format implementations. This class handles basic output operations and provides + * configurable behavior for quiet mode, output limiting. + */ +public abstract class BaseOutputFormat<T> implements OutputFormat<T> { + protected int limit; + protected CommandContext context; + + /** + * Creates a new {@link BaseOutputFormat} with specified configuration. + * + * @param context the command context, must not be null; + */ + public BaseOutputFormat(CommandContext context) { + Preconditions.checkNotNull(context, "CommandContext cannot be null"); + this.context = context; + this.limit = context.outputLimit(); + } + + /** + * Outputs a message to the specified OutputStream. This method handles both system streams + * ({@code System.out}, {@code System.err}) and regular output streams differently: - For system + * streams: Preserves the stream open after writing - For other streams: Automatically closes the + * stream after writing + * + * @param message the message to output, must not be null + * @param os the output stream to write to, must not be null If this is {@code System.out} or + * {@code System.err}, the stream will not be closed Review Comment: if they must not be null, why the null checks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
