this-user opened a new pull request, #6458:
URL: https://github.com/apache/gravitino/pull/6458
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Add two environment variables `GRAVITINO_JDBC_USER` and
`GRAVITINO_JDBC_PASSWORD` to the `rewrite_config.py`, so database user and
password can be set by the user in a container environment.
### Why are the changes needed?
Currently, JDBC user and PW are hardcoded to `iceberg` and cannot be changed
when using the container images. One workaround is including the values in the
JDBC connection string, but this neither elegant nor in line with how
containers commonly handle this issue.
### Does this PR introduce _any_ user-facing change?
Added the two aforementioned two environment variables that can be used by
the user.
### How was this patch tested?
Was tested locally only, since this is a minimal change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
