justinmclean commented on code in PR #6425:
URL: https://github.com/apache/gravitino/pull/6425#discussion_r1949971366
##########
clients/cli/src/test/java/org/apache/gravitino/cli/TestCatalogCommands.java:
##########
@@ -253,24 +246,22 @@ void testSetCatalogPropertyCommand() {
doReturn(mockSetProperty)
.when(commandLine)
.newSetCatalogProperty(
- GravitinoCommandLine.DEFAULT_URL,
- false,
- "metalake_demo",
- "catalog",
- "property",
- "value");
+ any(CommandContext.class),
+ eq("metalake_demo"),
+ eq("catalog"),
+ eq("property"),
+ eq("value"));
doReturn(mockSetProperty).when(mockSetProperty).validate();
commandLine.handleCommandLine();
verify(mockSetProperty).handle();
}
@Test
void testSetCatalogPropertyCommandWithoutPropertyAndValue() {
- Main.useExit = false;
Review Comment:
The issue is we don't want all tests to use this, only tests that throw an
exception should set this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
