yuqi1129 commented on code in PR #6376:
URL: https://github.com/apache/gravitino/pull/6376#discussion_r1944024074


##########
catalogs/catalog-hadoop/build.gradle.kts:
##########
@@ -52,6 +52,8 @@ dependencies {
     exclude("org.eclipse.jetty", "*")
     exclude("io.netty")
     exclude("org.fusesource.leveldbjni")
+    // Exclude protobuf-java to avoid conflict with;
+    exclude("com.google.protobuf", "protobuf-java")

Review Comment:
   I'm afraid excluding it in the gradle dependencies may be more general. 
   
   > since other package may introduce protobuf-java too.
   
   Some modules use copy task to exclude jars because using `excluding` in 
gradle does not work. I believe this is not a very elegant behaviour. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to