This is an automated email from the ASF dual-hosted git repository. roryqi pushed a commit to branch branch-0.8 in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/branch-0.8 by this push: new 591ee90761 [Minor] Change aliase to alias (#6387) 591ee90761 is described below commit 591ee90761c95d01cf9ac3c081663f5205f452e1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Tue Feb 4 00:59:33 2025 +0800 [Minor] Change aliase to alias (#6387) ### What changes were proposed in this pull request? The singular of aliases is alias not aliase. ### Why are the changes needed? See above. Fix: #N/A ### Does this PR introduce _any_ user-facing change? Yes, as it's a UI change. ### How was this patch tested? locally. Co-authored-by: Justin Mclean <jus...@classsoftware.com> Co-authored-by: roryqi <ror...@apache.org> --- docs/webui.md | 2 +- .../app/metalakes/metalake/rightContent/LinkVersionDialog.js | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/webui.md b/docs/webui.md index cf079d3f1c..ce3250a239 100644 --- a/docs/webui.md +++ b/docs/webui.md @@ -680,7 +680,7 @@ Click on the `LINK VERSION` button displays the dialog to link a version. Link a version needs these fields: 1. **URI**(**_required_**): the uri of the version. -2. **Aliases**(**_required_**): the aliases of the version, aliase cannot be number or number string. +2. **Aliases**(**_required_**): the aliases of the version, an alias cannot be a number or number string. 3. **Comment**(_optional_): the comment of the model. 4. **Properties**(_optional_): Click on the `ADD PROPERTY` button to add custom properties. diff --git a/web/web/src/app/metalakes/metalake/rightContent/LinkVersionDialog.js b/web/web/src/app/metalakes/metalake/rightContent/LinkVersionDialog.js index 01ea35b0c6..cd8ab59ef5 100644 --- a/web/web/src/app/metalakes/metalake/rightContent/LinkVersionDialog.js +++ b/web/web/src/app/metalakes/metalake/rightContent/LinkVersionDialog.js @@ -66,13 +66,13 @@ const schema = yup.object().shape({ yup.object().shape({ name: yup .string() - .required('This aliase is required') - .test('not-number', 'Aliase cannot be a number or numeric string', value => { + .required('The alias is required') + .test('not-number', 'Alias cannot be a number or a numeric string', value => { return value === undefined || isNaN(Number(value)) }) }) ) - .test('unique', 'Aliase must be unique', (aliases, ctx) => { + .test('unique', 'Alias must be unique', (aliases, ctx) => { const values = aliases?.filter(a => !!a.name).map(a => a.name) const duplicates = values.filter((value, index, self) => self.indexOf(value) !== index) @@ -81,7 +81,7 @@ const schema = yup.object().shape({ return ctx.createError({ path: `aliases.${duplicateIndex}.name`, - message: 'This aliase is duplicated' + message: 'This alias is duplicated' }) } @@ -326,7 +326,7 @@ const LinkVersionDialog = props => { field.onChange(event) trigger('aliases') }} - label={`Aliase ${index + 1}`} + label={`Alias ${index + 1}`} error={!!errors.aliases?.[index]?.name || !!errors.aliases?.message} helperText={errors.aliases?.[index]?.name?.message || errors.aliases?.message} fullWidth