FANNG1 commented on code in PR #6367:
URL: https://github.com/apache/gravitino/pull/6367#discussion_r1929709509


##########
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java:
##########
@@ -459,9 +460,16 @@ public static List<String> getMetadataObjectLocation(
               // The Hive default schema location is Hive warehouse directory
               String defaultSchemaLocation =
                   getHiveDefaultLocation(ident.namespace().level(0), 
ident.name());
-              if (defaultSchemaLocation != null && 
!defaultSchemaLocation.isEmpty()) {
+              if (StringUtils.isNotBlank(defaultSchemaLocation)) {
                 locations.add(defaultSchemaLocation);
               }
+            } else if (catalogObj.provider().equals("hadoop")) {
+              String catalogLocation = 
catalogObj.properties().get(HiveConstants.LOCATION);

Review Comment:
   The name for `catalog-common` is a little confusing, by design, it contains 
the constants shared by catalogs and connectors and Iceberg REST server, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to